feat: add missing spanner config properties #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rahul2393
commented
Jun 1, 2023
•
rahul2393
commented
- Update all deps
- Add support of setting rpcPriority
- Add support of setting numChannels
- Add support of setting databaseRole
- Add support of setting optimizerVersion
- Add support of setting optimizerStatisticsPackage
rahul2393
force-pushed
the
add_missing_connection_properties
branch
from
531412b to
aebaa09
Compare
harshachinta
reviewed
Jun 5, 2023
driver.go
Outdated
| default: | ||
| priority = spannerpb.RequestOptions_PRIORITY_UNSPECIFIED | ||
| } | ||
| config.ReadOptions = spanner.ReadOptions{Priority: priority} |
There was a problem hiding this comment.
Should we assign a default ReadOptions when creating config something like spanner.ReadOptions{} and then just assign user configured priority here like config.ReadOptions.Priority = priority, instead of overwriting ReadOptions?
Otherwise when user wants to configure RequestTag in ReadOptions it gets overwritten.
Same for others also TransactionOptions and QueryOptions
Correct me if i am missing something here.
There was a problem hiding this comment.
I guess we can directly do config.ReadOptions.Priority = priority because config.ReadOptions will be having default ReadOptions property set by default and will not be nil.
harshachinta
reviewed
Jun 5, 2023
driver.go
Outdated
| @@ -46,13 +47,22 @@ const userAgent = "go-sql-spanner/1.0.1" | |||
| // 3. (Optional) Parameters: One or more parameters in the format `name=value`. Multiple entries are separated by `;`. | |||
| // The supported parameters are: | |||
| // - credentials: File name for the credentials to use. The connection will use the default credentials of the | |||
| // environment if no credentials file is specified in the connection string. | |||
| // environment if no credentials file is spec`ified in the connection string. | |||
There was a problem hiding this comment.
Suggested change
| // environment if no credentials file is spec`ified in the connection string. | |
| // environment if no credentials file is specified in the connection string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.